Re: [PATCH 1/4] ASoC: dt-bindings: cs35l45: Adds ABPE properties

From: Krzysztof Kozlowski

Date: Fri Nov 13 2026 - 08:24:59 EST


On Mon, Nov 09, 2026 at 11:57:03AM -0600, Ricardo Rivera-Matos wrote:
> Adds devicetree properties to configure the amplifier brownout
> prevention engine (ABPE).
>
> Signed-off-by: Ricardo Rivera-Matos <rriveram@xxxxxxxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/sound/cirrus,cs35l45.yaml | 161 +++++++++++++++++++++
> 1 file changed, 161 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> index e674811b22b2..2c118fa57ad1 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> @@ -16,6 +16,62 @@ description: |
>
> allOf:
> - $ref: dai-common.yaml#

Entire allOf goes to the bottom, before additional/unevaluatedProps

> + - if:
> + required:
> + - cirrus,amplifier-bpe-enable
> + then:
> + required:
> + - cirrus,amplifier-bpe-response-mode
> + - cirrus,amplifier-bpe-thresholds-microvolt
> + - cirrus,amplifier-bpe-attack-rates
> + - cirrus,amplifier-bpe-hold-times-us

...

> + cirrus,amplifier-bpe-attenuation-levels-db:
> + description:
> + Amplifier BPE logarithmic audio output attenuation for levels L3, L2,
> + L1, L0, in whole dB steps. Half dB hardware settings are not
> + supported.
> + minItems: 4
> + maxItems: 4
> + items:
> + minimum: 0
> + maximum: 15
> +
> + cirrus,amplifier-bpe-attenuation-levels-microvolt:
> + description: |

Drop |, other places as well unless you need it.

> + Amplifier BPE linear voltage audio output attenuation for levels L3,
> + L2, L1, L0.
> + minItems: 4
> + maxItems: 4
> + items:
> + minimum: 187500
> + maximum: 1000000
> + multipleOf: 31250
> +

Best regards,
Krzysztof