Re: [PATCH v3 1/4] dt-bindings: arm: psci: Add skip-suspend-mode-switch property

From: Ulf Hansson

Date: Fri Nov 13 2026 - 08:35:04 EST


+ Sudeep

On Thu, Oct 22, 2026 at 11:41 AM Reza Kurniawan <imkyufie@xxxxxxxxx> wrote:
>
> From: Alejandro Tafalla <atafalla@xxxxxxxxx>
>
> On some SoCs (e.g. Qualcomm MSM8917 and MSM8937), PSCI_FEATURES reports
> that OS-initiated mode is supported, but every PSCI_SET_SUSPEND_MODE
> call is rejected with NOT_SUPPORTED.
>
> PSCI provides no call to read back the current suspend mode, so the OS
> cannot tell which mode the firmware is operating in or why the switch
> is rejected.
>
> Add an optional flag that tells the OS not to issue
> PSCI_SET_SUSPEND_MODE on such firmware.

I think it would be nice to further clarify what's going on in the
PSCI FW. If I understand correctly, the only supported mode is the
PSCI OS-initiated mode, hence it's always running in this mode, right?

This is clearly a violation of the PSCI spec - and I guess updating
the FW isn't possible at this late state, or is it?

>
> Signed-off-by: Alejandro Tafalla <atafalla@xxxxxxxxx>
> [Reza Kurniawan: split out the patch, rewrote the property description,
> renamed the property]
> Co-developed-by: Reza Kurniawan <imkyufie@xxxxxxxxx>
> Signed-off-by: Reza Kurniawan <imkyufie@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/psci.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml
> index 0d04389c81..2eee38d155 100644
> --- a/Documentation/devicetree/bindings/arm/psci.yaml
> +++ b/Documentation/devicetree/bindings/arm/psci.yaml
> @@ -98,6 +98,19 @@ properties:
> [1] Kernel documentation - ARM idle states bindings
> Documentation/devicetree/bindings/cpu/idle-states.yaml
>
> + skip-suspend-mode-switch:

Maybe a more descriptive name can be found?

osi-mode-only or broken-suspend-mode-osi-only?

> + $ref: /schemas/types.yaml#/definitions/flag
> + description: |
> + Do not issue PSCI_SET_SUSPEND_MODE.
> +
> + Some firmware advertises support for OS-initiated mode but rejects
> + every suspend mode switch with NOT_SUPPORTED. Since PSCI cannot report
> + the current mode, the OS cannot verify the state the firmware is in.
> +
> + This property is an assertion that the firmware works correctly without
> + a mode switch. This is a workaround for non-compliant firmware, only set
> + it for devices that ship with firmware known to behave this way.
> +
> patternProperties:
> "^power-domain-":
> $ref: /schemas/power/power-domain.yaml#
>
> --
> 2.56.0
>

Kind regards
Uffe