Re: [PATCH v9 3/7] EDAC/amd64: Stop matching Hygon CPUs

[Lin Wang]

Hi Boris,

On 11/13/2026 12:52 PM, Borislav Petkov wrote:
> On Thu, Oct 29, 2026 at 01:33:09PM +0800, Lin Wang wrote:
> > amd64_edac gets its node count and DF devices from the AMD northbridge
> > cache. Since commit 49b96fc0dddc ("x86/amd_nb: Simplify function 3
> This commit is old. Should that patch be in stable?

I don't plan to backport this to stable. It is part of separating
Hygon support from the AMD code in this series.

> > search"), the cache finds function 3 only at the fixed PCI slots
> > 0x18 + N. Hygon DF devices are not at those slots, so the cache is
> > discarded on Hygon and amd64_edac_init() returns -ENODEV at its
> > amd_nb_num() check.
> Please do not explain the code in the patch commit messages. Only the
> non-obvious stuff.
>
> > Remove the Hygon match and the empty Family 0x18 case.
> That's what the patch does, no?
>
>
> > MCE decoding
> > in mce_amd.c is separate and unchanged. Hygon memory controller support
> > will use the Hygon node interfaces in a separate series.
> This is unnecessary.
>
> Please concentrate only on why a patch exists. No meandering, no obvious code
> explaining, just to the point.
>
> Check your whole set pls.

I'll reword the commit messages across the series to focus on why
each change is needed.

Thanks,

Lin