Re: [PATCH net-next V2 02/13] net/mlx5: Detach auxiliary devices on attach failure during load

[Dragos Tatulea]

On 12.11.26 10:40, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
> 
> Low priority / nit picks for your consideration:
> 
> - [Low] The commit message says the fix "doesn't deserve a Fixes tag"
>   because the bug was found by code inspection and never reproduced.
> 
> --
> 
> net/mlx5: Detach auxiliary devices on attach failure during load
> 
> This patch adds a mlx5_detach_device() call to the err_attach path of
> mlx5_load_one_devl_locked(). The goal is to detach the auxiliary devices
> that attached successfully before mlx5_attach_device() hit a failure.
> 
>> This issue was found during code inspection and was not reproduced.
>> Hence it doesn't deserve a Fixes tag.
> 
> [Severity: Low]
> Is this a valid reason to leave out the Fixes tag? The Fixes convention
> points at the commit that introduced the bug. It doesn't exempt bugs that
> were found by inspection and never reproduced.
> 
I will leave the maintainers to respond to this. But I think it is
fine as is.

Thanks,
Dragos