Re: [PATCH] bus: mhi: pci_generic: Fix erroneous system suspend abort
From: Len Brown
Date: Fri Nov 13 2026 - 09:45:16 EST
> > This 1-line fix should be applied NOW, without waiting for internal
> > mhi internal or development.
>
> Fair enough, but would only ignoring error on -EBUSY would work for
> you? as this is clearly something which is not relevant for system
> wide suspend cases.
Although I've seen only -EBUSY, I would turn that around...
Are there ANY mhi suspend cases that merit aborting system wide suspend?
If there are, then check for those and explicitly abort system suspension.
(experience shows that these scenarios are quite rare, and it would
be remarkable if there were such a condition here)
> Also would it be possible to add a small inline comment saying we
> purposely ignore this because of buggy mhi suspend handling.
I agree. I'll add a comment to clarify.
> With your patch what happens on the system resume path? is the MHI
> device recovered?
This laptop is generally quite a good suspend-resume regression test bed.
It does actually have a wireless modem, but AFAIK, the device itself
is always unused.
$ lspci -nnk | grep -B 2 -A 3 -i mhi
08:00.0 Unassigned class [ff00]: Quectel Wireless Solutions Co., Ltd.
Device [1eac:1007]
Subsystem: Quectel Wireless Solutions Co., Ltd. Device [1eac:100c]
Kernel driver in use: mhi-pci-generic
Kernel modules: mhi_pci_generic
I have over 28,000 suspend resume results on its local drive, dating
back to Linux-7.2.
The most recent 3,000 cycles included this one line patch and showed no issues.
There were 9 suspend failures on a run of 2,500 suspend cycles run Nov
8 - Nov 9.
I've attached the mhi messages, as they'd wrap if I pasted them here.
Twice we see this:
mhi-pci-generic 0000:08:00.0: Unbalanced pm_runtime_enable!
perhaps a hint?
thanks,
-Len
ps. apology for the previous top-post.
suspend-261108-235706/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[ 858.658113] mhi-pci-generic 0000:08:00.0: failed to suspend device: -16
suspend-261108-235706/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[ 858.658133] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend(): mhi_pci_suspend [mhi_pci_generic] returns -16
suspend-261108-235706/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[ 858.658149] mhi-pci-generic 0000:08:00.0: PM: dpm_run_callback(): pci_pm_suspend returns -16
suspend-261108-235706/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[ 858.658159] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend returned -16 after 15145 usecs
suspend-261108-235706/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[ 858.658162] mhi-pci-generic 0000:08:00.0: PM: failed to suspend async: error -16
suspend-261109-023323/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[10240.621426] mhi-pci-generic 0000:08:00.0: failed to suspend device: -16
suspend-261109-023323/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[10240.621484] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend(): mhi_pci_suspend [mhi_pci_generic] returns -16
suspend-261109-023323/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[10240.621501] mhi-pci-generic 0000:08:00.0: PM: dpm_run_callback(): pci_pm_suspend returns -16
suspend-261109-023323/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[10240.621510] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend returned -16 after 88 usecs
suspend-261109-023323/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[10240.621513] mhi-pci-generic 0000:08:00.0: PM: failed to suspend async: error -16
suspend-261109-024206/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[10763.773690] mhi-pci-generic 0000:08:00.0: failed to suspend device: -16
suspend-261109-024206/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[10763.773705] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend(): mhi_pci_suspend [mhi_pci_generic] returns -16
suspend-261109-024206/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[10763.773716] mhi-pci-generic 0000:08:00.0: PM: dpm_run_callback(): pci_pm_suspend returns -16
suspend-261109-024206/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[10763.773722] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend returned -16 after 34 usecs
suspend-261109-024206/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[10763.773725] mhi-pci-generic 0000:08:00.0: PM: failed to suspend async: error -16
suspend-261109-044656/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[18254.529615] mhi-pci-generic 0000:08:00.0: failed to suspend device: -16
suspend-261109-044656/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[18254.529632] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend(): mhi_pci_suspend [mhi_pci_generic] returns -16
suspend-261109-044656/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[18254.529651] mhi-pci-generic 0000:08:00.0: PM: dpm_run_callback(): pci_pm_suspend returns -16
suspend-261109-044656/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[18254.529660] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend returned -16 after 48 usecs
suspend-261109-044656/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[18254.529662] mhi-pci-generic 0000:08:00.0: PM: failed to suspend async: error -16
suspend-261109-044821/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[18339.528817] mhi-pci-generic 0000:08:00.0: failed to suspend device: -16
suspend-261109-044821/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[18339.528831] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend(): mhi_pci_suspend [mhi_pci_generic] returns -16
suspend-261109-044821/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[18339.528839] mhi-pci-generic 0000:08:00.0: PM: dpm_run_callback(): pci_pm_suspend returns -16
suspend-261109-044821/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[18339.528845] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend returned -16 after 31 usecs
suspend-261109-044821/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[18339.528847] mhi-pci-generic 0000:08:00.0: PM: failed to suspend async: error -16
suspend-261109-053226/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[20984.601312] mhi-pci-generic 0000:08:00.0: failed to suspend device: -16
suspend-261109-053226/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[20984.601346] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend(): mhi_pci_suspend [mhi_pci_generic] returns -16
suspend-261109-053226/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[20984.601354] mhi-pci-generic 0000:08:00.0: PM: dpm_run_callback(): pci_pm_suspend returns -16
suspend-261109-053226/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[20984.601359] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend returned -16 after 55 usecs
suspend-261109-053226/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[20984.601361] mhi-pci-generic 0000:08:00.0: PM: failed to suspend async: error -16
suspend-261109-053240/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[20997.534278] mhi-pci-generic 0000:08:00.0: Unbalanced pm_runtime_enable!
suspend-261109-053240/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[20997.561203] mhi-pci-generic 0000:08:00.0: Unbalanced pm_runtime_enable!
suspend-261109-053519/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[21157.715248] mhi-pci-generic 0000:08:00.0: failed to suspend device: -16
suspend-261109-053519/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[21157.715264] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend(): mhi_pci_suspend [mhi_pci_generic] returns -16
suspend-261109-053519/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[21157.715277] mhi-pci-generic 0000:08:00.0: PM: dpm_run_callback(): pci_pm_suspend returns -16
suspend-261109-053519/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[21157.715287] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend returned -16 after 41 usecs
suspend-261109-053519/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[21157.715291] mhi-pci-generic 0000:08:00.0: PM: failed to suspend async: error -16
suspend-261109-054114/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[21512.348289] mhi-pci-generic 0000:08:00.0: failed to suspend device: -16
suspend-261109-054114/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[21512.348335] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend(): mhi_pci_suspend [mhi_pci_generic] returns -16
suspend-261109-054114/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[21512.348355] mhi-pci-generic 0000:08:00.0: PM: dpm_run_callback(): pci_pm_suspend returns -16
suspend-261109-054114/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[21512.348365] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend returned -16 after 77 usecs
suspend-261109-054114/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[21512.348368] mhi-pci-generic 0000:08:00.0: PM: failed to suspend async: error -16
suspend-261109-091429/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[34308.085783] mhi-pci-generic 0000:08:00.0: failed to suspend device: -16
suspend-261109-091429/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[34308.085793] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend(): mhi_pci_suspend [mhi_pci_generic] returns -16
suspend-261109-091429/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[34308.085801] mhi-pci-generic 0000:08:00.0: PM: dpm_run_callback(): pci_pm_suspend returns -16
suspend-261109-091429/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[34308.085807] mhi-pci-generic 0000:08:00.0: PM: pci_pm_suspend returned -16 after 25 usecs
suspend-261109-091429/lenb-thinkpad-t16-gen-3_freeze_dmesg.txt:[34308.085809] mhi-pci-generic 0000:08:00.0: PM: failed to suspend async: error -16