Re: [PATCH v2 2/3] drm/panthor: Add initial support for CIX Sky1
From: Daniel Stone
Date: Fri Nov 13 2026 - 10:00:58 EST
Hi Cunyuan,
On Wed, 11 Nov 2026 at 13:16, Cunyuan Liu <cunyuan.liu@xxxxxxxxxxx> wrote:
> On 2026-11-10 10:03:46 +0000, Liviu Dudau wrote:
> > > +static const struct panthor_sysc_config sysc_config_cix_sky1 = {
> > > + /* Sky1 needs these SYSC_ALLOC policies for correct display of GPU output. */
> > > + .alloc = {
> > > + 0x00230000, 0x00000023, 0x00000000, 0x00000000,
> > > + 0x00523222, 0x00523200, 0x00000022, 0x00000032,
> > > + },
> > > +};
> >
> > These should not be in the driver but in the device tree bindings. If you extract
> > the system cache code into a separate patch we can have a proper discussion there.
>
> I will move the eight SYSC_ALLOC values into a DT property, such as
> arm,sysc-alloc, and submit the system-cache support as a separate patch.
Whilst doing this, please break the properties out. At the moment,
it's written as 32-bit groups of 4 source+RW pairs. I would much
prefer to have groups of [<sourceR, sourceW>, <sourceR, sourceW>, ...]
than just the raw register values to be dumped into SYSC_ALLOC*.
FWIW, I agree with everything else Liviu said. I don't have a strong
opinion on skipping out devfreq if OPPs are not present vs. exposing a
single fixed OPP from the clock provider, but the former does seem
better for me.
Cheers,
Daniel