Re: [PATCH 2/9] scsi: ufs: core: Defer link recovery on reserved PM command timeout
From: Stanley Jhu
Date: Fri Nov 13 2026 - 10:13:55 EST
On Thu, Nov 12, 2026 at 07:19:32AM -0800, Bart Van Assche wrote:
> I don't like the approach of this patch series. I think this series
> changes much more code than what is necessary. There is a much simpler
> way to fix the issue reported in the cover letter: instead of calling
> ufshcd_link_recovery(hba) from ufshcd_eh_timed_out(), remove that call
> from ufshcd_eh_timed_out() and instead call ufshcd_link_recovery(hba)
> from ufshcd_set_dev_pwr_mode() if the SCSI error code returned by
> ufshcd_execute_start_stop() indicates that the SCSI START STOP UNIT
> command has timed out.
Agreed. Recovering the link from ufshcd_set_dev_pwr_mode() is much
simpler and avoids adding new driver state.
I have sent v2 as a 2-patch series following this approach:
https://lore.kernel.org/r/20261113111202.3551341-1-stanleyjhu@xxxxxxxxxx