Re: [PATCH 2/5] Input: tsc2007 - remove unneeded memory barriers
From: Andy Shevchenko
Date: Fri Nov 13 2026 - 10:14:41 EST
On Thu, Nov 12, 2026 at 8:50 AM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>
> The driver invokes mb() after setting the stopped flag in tsc2007_stop()
> and tsc2007_open(). These mandatory barriers lack pairing barriers on
> the reader side and are unnecessary.
...and they lack the comment why.
> The wait queue operations wake_up() and wait_event_timeout(), along
> with disable_irq() and enable_irq(), already provide the required
> synchronization and memory ordering when stopping and starting the
> touchscreen worker thread. Remove the redundant barriers.
Reviewed-by: Andy Shevhcneko <andy@xxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko