Re: [PATCH v6 00/15] Add splash DRM client

[Thomas Zimmermann]

Hi

Am 12.11.26 um 16:22 schrieb Màxim Pedraza Padilla:
> Hi Thomas, Javier, Francesco,
>
> Thanks a lot for the reviews. I'm answering everything here in one go.
>
> On 11/11/26 14:52, Thomas Zimmermann wrote:
> > So shall we merge patches 1 to 6 and 8 first? You'd have something in
> > upstream already and not chase a moving target. From there, we can merge
> > the other features in the coming weeks.
> Yes, that sounds great. v7 is ready and holds just those: patches 1 to 4,
> 6 and 8 of v6, with the MAINTAINERS entry squashed into the patch that
> adds drm_splash.c, so six patches in all. The DT binding, the placement
> and rotation, and the connector orientation will follow as a separate
> series once this one is in.
>
> What changes in v7 from your comments:
>
> - the Assisted-by tags are gone from every patch (Javier)
> - MAINTAINERS: I'm listed as M: and Francesco as R: (thanks, Francesco),
>    in the same patch as drm_splash.c
> - the firmware source is now DRM_SPLASH_SRC_FW, and the Kconfig options
>    DRM_CLIENT_SPLASH_SRC_FW and DRM_CLIENT_SPLASH_FW_NAME; the BMP decoder
>    keeps its name, since the BGRT goes through it too
> - the drm_splash_fw_load() stub returns 0
>
> On the CONFIG_X86 around the BGRT check in patch 4: it comes from efifb,
> where efifb_bgrt_sanity_check() is x86 only too, and its comment says
> that all x86 firmwares centre the image horizontally. I haven't found
> that promised for other architectures, and there the check could reject
> a logo that is fine, so I'd rather keep it as efifb does. If you prefer
> it on every architecture, or gone, I'll change it.
>
> The issue Sashiko found on v6 (a restore deferred while the device was
> suspended) is fixed in v7, together with a few more that a later Sashiko
> run found; the changelog of patch 4 lists them.
>
> About your Reviewed-by on patch 4: since v6 the work has changed quite a
> bit. Restore now leaves the commit to the work, a hotplug while userspace
> holds the display waits for the next restore as fbdev does, and
> unregister waits for the work before it looks for a pending firmware
> request. Shall I keep your tag, or drop it so you can look at the new
> version first? Whichever you prefer.

Keep the R-b. I intend to merge the next iteration. Any issues can then 
still be sorted out. The splash screen has been waiting out of tree for 
far too long.

Best regards
Thomas

> I'll send v7 shortly.
>
> Best regards,
> Màxim

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)