Re: [PATCH] pinctrl: qcom: sm8650-lpass-lpi: Force runtime suspend on system sleep
From: Bartosz Golaszewski
Date: Fri Nov 13 2026 - 10:26:51 EST
On Thu, Nov 12, 2026 at 09:59:57PM +0530, Gopi Chandra Sekhar Reddy Kanala wrote:
> Yes. All the LPASS LPI drivers share lpi_pinctrl_probe(),
> which manages the clocks through pm_clk with runtime PM, and every SoC
> driver has the same runtime-only dev_pm_ops, so they should all have
> the same problem.
>
While they're the same, they don't reimplement the same callbacks, they all
use the standard PM helpers so it's not like we're wasting that much
memory.
That being said, I won't reject a patch that moves them all together.
> For v2, I was thinking of two patches:
>
> 1. Move the dev_pm_ops into pinctrl-lpass-lpi.c, export it, and use it
> from all the SoC drivers (no functional change).
> 2. Add the system sleep callbacks to the shared dev_pm_ops.
>
> Would that be okay, or is it preferable to add the system sleep callbacks to
> each SoC driver instead?
>
I'm fine either way, but it might indeed be more elegant to centralize it.
> I can only test on Glymur CRD (sm8650 driver), so the other SoC drivers
> would be compile-tested only.
>
> Gopi
Please don't top-post on the mailing list.
Thanks,
Bartosz