RE: [PATCH v6 6/8] iio: imu: adis16607: Add FIFO-based buffered capture

From: Sabau, Radu bogdan

Date: Fri Nov 13 2026 - 11:23:34 EST


> -----Original Message-----
> From: Radu Sabau via B4 Relay <devnull+radu.sabau.analog.com@xxxxxxxxxx>
> Sent: Friday, November 13, 2026 2:34 PM

...

> +static int adis16607_set_watermark(struct iio_dev *indio_dev, unsigned int
> val)
> +{
> + struct adis16607 *st = iio_priv(indio_dev);
> +
> + val = clamp(val, 1, ADIS16607_MAX_FIFO_WM);
> + st->fifo_watermark = val;
> +
> + return 0;
> +}
> +

Sashiko reported that the initial fifo_watermark set in probe() is
overwritten when the buffer is enabled: the kfifo buffer's watermark
defaults to 1 and iio_enable_buffers() passes it to
hwfifo_set_watermark() before postenable().

That's correct. The device watermark always follows buffer/watermark;
the value from probe() only affects what hwfifo_watermark shows before
the first enable. I'll initialize it to 1 in v7 so it is consistent.