Re: [PATCH] serial: sc16is7xx: Fix clock leak on invalid clock frequency

From: Hugo Villeneuve

Date: Fri Nov 13 2026 - 12:19:12 EST


Hi Xiangwu,

On Fri, 13 Nov 2026 18:37:54 +0800
Xiangwu Lai <laixiangwu@xxxxxxxxxxxxxxxxxxxx> wrote:

> Hi Hugo,
>
> thanks for the review!
>
> Agreed, devm_clk_get_optional_enabled() is the cleaner way: the clock
> reference is dropped and the clock disabled automatically on probe
> failure and on remove, so the manual management, the out_clk label
> and the clk_disable_unprepare() in sc16is7xx_remove() all go away,
> and the -EINVAL path keeps its original plain return.
>
> I've reworked the patch accordingly; v2 follows shortly.
>
> Best regards,
> Xiangwu Lai

Great.

But once again, there is no context as you didn't reply to the original
email.

Please always reply to the original email.

--
Hugo Villeneuve