Re: [PATCH v4 3/3] arm64: dts: qcom: sm8750: describe all MDSS block resets
From: Qianhui Xu
Date: Fri Nov 13 2026 - 12:21:24 EST
Hi Konrad,
thanks for the Reviewed-by.
Replying to the sashiko finding as well, because it raises a point I should
answer properly rather than wave away: is 0xa000 a secondary display core
domain rather than the interrupt block?
Partly yes, and my commit message overstated it. Let me separate what is
established from what is not.
What the DT and the driver currently describe:
- mdss is an interrupt controller: "interrupt-controller;" plus
"#interrupt-cells = <1>", and its children take IRQs through it --
DPU "interrupts-extended = <&mdss 0>", DSI0 "<&mdss 4>", DSI1 "<&mdss 5>".
- The mdss irqchip itself only reads one status register and demultiplexes
(msm_mdss.c, offset 0x10). It has no per-line enable/ack registers; the
mask is a software bitmap. The block that does have clear/en/status is
MDP TOP's INTR/INTR2 group, driven by the DPU driver.
- dispcc-sm8750 does describe 0xa000 as its own domain: its own GDSC
(mdss_int2_gdsc at 0xb000) and its own clock family (disp_cc_mdss_mdp1_clk,
disp_cc_mdss_ahb1_clk, ...).
- The mdss node does not attach that domain: power-domains is MDSS_GDSC only,
and the clocks list has AHB_CLK/MDP_CLK/GCC_DISP_HF_AXI_CLK, no mdp1 family.
So the reviewer is right that 0xa000 is not "the mdss interrupt controller"
and that asserting its BCR reaches into a domain the mdss device has not
attached. That is a fair reading of the code.
What the measurement says, and its limit:
On this board, resetting only DISP_CC_MDSS_CORE_BCR leaves the display
intermittently broken at cold boot: 5 of 9 cold PORs fail with
msm_dsi ae94000.dsi: command DMA timeout: status=0x2200200
panel-novatek-nt36536: Failed to initialize panel: -5
whereas the same kernel asserting the group gave 15/15 clean boots.
Two limits on that number, both of which I should state rather than let the
"15/15" look stronger than it is:
- That arm asserted three resets (0x8000 + 0xa000 + 0xc000), because it was
the shape before you asked for RSCC to be dropped. The two-reset shape in
this v4 has not been booted; the driver-side change is the same, so I expect
it to behave the same, but that is an expectation and not a measurement.
- I have not isolated 0xa000 as a single variable either. The correlation is
with the group, not with any one member, so I am not claiming 0xa000 is the
sole cause -- the honest statement is that asserting the group is what
tracks with a working display.
What I do not have: a datasheet-level statement that the INTR2 group and the
0xa000 domain are the same hardware block. My evidence for that is naming
(dispcc calls the reset ..._CORE_INT2_BCR, the GDSC MDSS_INT2_GDSC, MDP TOP
calls its second group INTR2) plus structure (same MDSS core, separate
BCR/GDSC within it). That is why v4 no longer claims INT2 "was left out of
reset and caused the DMA timeouts"; the message only states what dispcc
provides and that firmware hands over with the display block running.
Given all of that, two honest options, and I would take whichever you and
Dmitry prefer:
a) keep the series as is, with the commit message narrowed to what is
observable (group reset correlates with clean cold boots; no causal
claim about INT2), and
b) split 3/3 out and drop it, keeping only 2/3 (the array API change,
which is uncontroversial), and revisit the SM8750 second reset once
someone can confirm the block boundary from documentation.
My preference is (a) because the failing boot is reproducible on this
hardware and the group is what fixes it, but (b) is cleaner if you consider
the un-attached-domain concern disqualifying. I can send a v5 either way,
including a reworded 3/3 that drops the "interrupt controller" framing and
describes only "a second block reset provided by dispcc for the MDSS core".
Unless you would rather have (b), I will go with (a) and send a v5 whose only
change is the 3/3 commit message below -- the diff stays byte-identical to v4,
and your Reviewed-by is carried over. If you would prefer (b) instead, say so
and I will drop 3/3 from the series.
--- >8 ---
arm64: dts: qcom: sm8750: describe the second MDSS block reset
The SM8750 display clock controller provides two block resets for the
MDSS core area: DISP_CC_MDSS_CORE_BCR and DISP_CC_MDSS_CORE_INT2_BCR,
at 0x8000 and 0xa000. The second one belongs to a domain that dispcc
describes with its own GDSC (mdss_int2_gdsc) and its own clock family
(disp_cc_mdss_mdp1_clk, disp_cc_mdss_ahb1_clk, ...).
Bootloaders hand over with the display hardware still running, so the
MDSS reset should return the whole group to a known state before any
display hardware is programmed. Describe both resets so that the
array-API change in the previous patch asserts and releases the group
together.
On this board, resetting only DISP_CC_MDSS_CORE_BCR leaves the display
intermittently broken at cold boot (command DMA timeouts followed by a
panel init failure, 5 of 9 cold PORs), while asserting the group gave
15 clean boots out of 15. That measurement used the three-reset shape
that also included RSCC; it has not been repeated for this two-reset
shape, and the second reset has not been isolated as a single variable.
What is observable is that resetting the group correlates with a working
display at cold boot.
Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Signed-off-by: Qianhui Xu <xiaqinghuan@xxxxxxxxxxxxxxxx>
--- 8< ---
One more thing worth stating explicitly: this series was written with AI
assistance. I reviewed and edited every line, the measurements above are
mine, and I am responsible for the content.
Thanks,
Qianhui