[PATCH] spi: sunplus-sp7021: use devm_reset_control_get_exclusive_deasserted()

From: Felix Gu

Date: Fri Nov 13 2026 - 12:30:03 EST


Use devm_reset_control_get_exclusive_deasserted() to replace the
explicit reset acquisition, deassertion, and cleanup action registered
with devm_add_action_or_reset().

This simplifies reset handling and removes the custom reset assertion
callback while preserving reset assertion during cleanup.

Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
---
drivers/spi/spi-sunplus-sp7021.c | 18 +++---------------
1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/drivers/spi/spi-sunplus-sp7021.c b/drivers/spi/spi-sunplus-sp7021.c
index 54431c363bbc..abb272dd7250 100644
--- a/drivers/spi/spi-sunplus-sp7021.c
+++ b/drivers/spi/spi-sunplus-sp7021.c
@@ -393,11 +393,6 @@ static int sp7021_spi_target_transfer_one(struct spi_controller *ctlr, struct sp
return ret;
}

-static void sp7021_spi_reset_control_assert(void *data)
-{
- reset_control_assert(data);
-}
-
static int sp7021_spi_controller_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -463,17 +458,10 @@ static int sp7021_spi_controller_probe(struct platform_device *pdev)
if (IS_ERR(pspim->spi_clk))
return dev_err_probe(dev, PTR_ERR(pspim->spi_clk), "clk get fail\n");

- pspim->rstc = devm_reset_control_get_exclusive(dev, NULL);
+ pspim->rstc = devm_reset_control_get_exclusive_deasserted(dev, NULL);
if (IS_ERR(pspim->rstc))
- return dev_err_probe(dev, PTR_ERR(pspim->rstc), "rst get fail\n");
-
- ret = reset_control_deassert(pspim->rstc);
- if (ret)
- return dev_err_probe(dev, ret, "failed to deassert reset\n");
-
- ret = devm_add_action_or_reset(dev, sp7021_spi_reset_control_assert, pspim->rstc);
- if (ret)
- return ret;
+ return dev_err_probe(dev, PTR_ERR(pspim->rstc),
+ "failed to get and deassert reset\n");

ret = devm_request_irq(dev, pspim->m_irq, sp7021_spi_host_irq,
IRQF_TRIGGER_RISING, pdev->name, pspim);

---
base-commit: 793807ca13bf3072fc6d16ce6d90e9ab9beff2a5
change-id: 20261114-sunplus-reset-cleanup-6f05470b018e

Best regards,
--
Felix Gu <ustc.gu@xxxxxxxxx>