Re: [PATCH v2 6/8] driver core: platform: tests: fix swnode reuse test description

From: Rafael J. Wysocki (Intel)

Date: Fri Nov 13 2026 - 13:14:47 EST


On Tue, Nov 10, 2026 at 9:52 AM Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> The description of the software node reuse test is misleading as a
> software node being registered does not prevent it from being reused
> (e.g. as software nodes can be shared).
>
> Fix the description by clarifying that the test would fail if the
> secondary software node is not removed from the device so that the
> reused primary firmware node still points to the software node.

LGTM

Acked-by: Rafael J. Wysocki (Intel) <rafael@xxxxxxxxxx>

> Fixes: 397f0a3958c9 ("driver core: platform: tests: add test cases for correct swnode removal")
> Cc: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> ---
> drivers/base/test/platform-device-test.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/test/platform-device-test.c b/drivers/base/test/platform-device-test.c
> index 9ce563f76aad..b0cc37d166ff 100644
> --- a/drivers/base/test/platform-device-test.c
> +++ b/drivers/base/test/platform-device-test.c
> @@ -273,9 +273,10 @@ static const struct software_node platform_device_test_swnode = { };
> /*
> * Check that reusing a software node works correctly. If the call to
> * platform_device_register_full() fails after adding the secondary firmware
> - * node, the software node must be unregistered in the device's release()
> + * node, the software node must be removed in the device's release()
> * callback or the subsequent call to platform_device_register_full() will fail
> - * with -EBUSY due to the software node already having been registered.
> + * with -EBUSY due to the primary firmware node still pointing at the
> + * secondary software node.
> */
> static void platform_device_swnode_add_twice(struct kunit *test)
> {
> --
> 2.56.0
>