[PATCH v4 22/58] mtd: rawnand: pasemi: retain open-handle state on removal
From: James Hilliard
Date: Fri Nov 13 2026 - 14:08:30 EST
Keep chip metadata and controller storage alive until the final MTD
reference is released. Unregister and disconnect each published chip
before releasing the resources used by its hardware operations.
Release the LPC region and NAND mapping after disconnection.
Run NAND cleanup during disconnection; the final core-owned put only
releases retained allocation and layout data.
Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx>
---
drivers/mtd/nand/raw/pasemi_nand.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/raw/pasemi_nand.c b/drivers/mtd/nand/raw/pasemi_nand.c
index b497e84636c1..0a2d5e5bae07 100644
--- a/drivers/mtd/nand/raw/pasemi_nand.c
+++ b/drivers/mtd/nand/raw/pasemi_nand.c
@@ -122,8 +122,10 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
chip = &ddata->chip;
controller = &ddata->controller;
+ err = devm_nand_controller_init(dev, controller, ddata);
+ if (err)
+ return err;
controller->ops = &pasemi_ops;
- nand_controller_init(controller);
chip->controller = controller;
pasemi_nand_mtd = nand_to_mtd(chip);
@@ -136,7 +138,7 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
if (!chip->legacy.IO_ADDR_R) {
err = -EIO;
- goto out_mtd;
+ goto out;
}
pdev = pci_get_device(PCI_VENDOR_ID_PASEMI, 0xa008, NULL);
@@ -174,10 +176,15 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
if (err)
goto out_lpc;
+ err = nand_set_lifetime(chip, NULL);
+ if (err)
+ goto out_cleanup_nand;
if (mtd_device_register(pasemi_nand_mtd, NULL, 0)) {
dev_err(dev, "Unable to register MTD device\n");
err = -ENODEV;
- goto out_cleanup_nand;
+ nand_disconnect(chip);
+ mtd_put_master(pasemi_nand_mtd);
+ goto out_lpc;
}
dev_info(dev, "PA Semi NAND flash at %pR, control at I/O %x\n", &res,
@@ -191,8 +198,6 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
release_region(ddata->lpcctl, 4);
out_ior:
iounmap(chip->legacy.IO_ADDR_R);
- out_mtd:
- kfree(ddata);
out:
return err;
}
@@ -210,14 +215,13 @@ static void pasemi_nand_remove(struct platform_device *ofdev)
/* Release resources, unregister device */
ret = mtd_device_unregister(pasemi_nand_mtd);
WARN_ON(ret);
- nand_cleanup(chip);
+ nand_disconnect(chip);
release_region(ddata->lpcctl, 4);
iounmap(chip->legacy.IO_ADDR_R);
- /* Free the MTD device structure */
- kfree(ddata);
+ mtd_put_master(pasemi_nand_mtd);
}
static const struct of_device_id pasemi_nand_match[] =
--
2.53.0