Re: [PATCH v4 2/3] MIPS: Ingenic: Add XBurst SMP support

[Florian Fainelli]

On 11/13/26 10:07, Florian Fainelli wrote:
> > Drop the macro guards:
> > .cpu_disable = IF_PTR(IS_ENABLED(CONFIG_HOTPLUG_CPU), 
> > xburst_cpu_disable),
>
> OK.

On that suggestion specifically, the member cpu_disable does not exist 
when CONFIG_HOTPLUG_CPU is not defined, so although PTR_IF() evaluates 
to NULL, we are still trying to assign to a non-existent member, which 
won't work. I did make the callback always defined and used 
__maybe_unused instead.
--
Florian