Re: [PATCH 2/2] mm/ksm: add initialization helpers for scan_get_next_rmap_item()
From: David Hildenbrand (Arm)
Date: Fri Nov 13 2026 - 14:13:33 EST
On 11/12/26 13:59, Xu Xin (vivo) wrote:
> Extract the new scan cycle detection (including draining per-CPU LRU
> caches) and advancing the scan cursor to the first mm_slot into
> scan_begin_new_cycle() and scan_get_first_mm().
>
> This keeps the exact execution order intact while making
> scan_get_next_rmap_item() cleaner and easier to follow.
>
> No functional change intended.
>
> Signed-off-by: Xu Xin (vivo) <xu.xin@xxxxxxxxx>
> ---
> mm/ksm.c | 70 +++++++++++++++++++++++++++++++++++++-------------------
> 1 file changed, 46 insertions(+), 24 deletions(-)
>
> diff --git a/mm/ksm.c b/mm/ksm.c
> index 49977bcf04f7..e79e64372e49 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -2640,6 +2640,49 @@ static void ksm_reset_unstable_trees(void)
> root_unstable_tree[nid] = RB_ROOT;
> }
>
> +static bool scan_begin_new_cycle(void)
> +{
> + /* Check if the cursor points to the head. */
> + if (ksm_scan.mm_slot != &ksm_mm_head)
> + return false;
> +
> + /*
> + * A number of pages can hang around indefinitely in per-cpu
> + * LRU cache, raised page count preventing write_protect_page
> + * from merging them. Though it doesn't really matter much,
> + * it is puzzling to see some stuck in pages_volatile until
> + * other activity jostles them out, and they also prevented
> + * LTP's KSM test from succeeding deterministically; so drain
> + * them here (here rather than on entry to ksm_do_scan(),
> + * so we don't IPI too often when pages_to_scan is set low).
> + */
> + lru_add_drain_all();
> + return true;
> +}
> +
> +static struct ksm_mm_slot *scan_get_first_mm(void)
> +{
> + struct ksm_mm_slot *mm_slot = ksm_scan.mm_slot;
> + struct mm_slot *slot;
> +
> + spin_lock(&ksm_mmlist_lock);
> +
> + slot = list_entry(mm_slot->slot.mm_node.next, struct mm_slot, mm_node);
> + mm_slot = mm_slot_entry(slot, struct ksm_mm_slot, slot);
> + ksm_scan.mm_slot = mm_slot;
> +
> + spin_unlock(&ksm_mmlist_lock);
> +
> + /*
> + * Although we tested list_empty() above, a racing __ksm_exit
> + * of the last mm on the list may have removed it since then.
> + */
> + if (mm_slot == &ksm_mm_head)
> + return NULL;
> +
> + return mm_slot;
> +}
I like this function cleanup here, but not sure about the other one.
Can we just leave the lru_add_drain_all() where it is, or what's the reason for
that change?
Note that that might soon get removed either way, so I wouldn't worry about it.
Then, I would rename the function into something like
"scan_should_start_new_cycle"
And keep it simple.
--
Cheers,
David