Re: [PATCH v5 18/29] sched/deadline: Move a task's bandwidth only where room was made

From: Andrea Parri

Date: Fri Nov 13 2026 - 14:21:45 EST


On Fri, Nov 13, 2026 at 08:35:03AM -0500, Mathieu Desnoyers wrote:
> Hi Juri,
>
> > > +/* The caller made room for the deadline bandwidth in the new root domain. */
> > > +#define SCA_DL_BW_RESERVED 0x20
> >
> > Why not 0x10?
>
> No reason. 0x10 is free. The planned next version uses it.

Hi Mathieu,

A heads-up, since both are under review: [1] adds SCA_DL_CHECK as
0x10, so if your next version also takes 0x10 and both get merged,
the result would build with the two flags silently sharing a bit.

Your plan in [2] to change the affinity check and the early exit also
overlaps [1], which moves dl_task_check_affinity() into
__set_cpus_allowed_ptr_locked(), right above that early exit.

I'm happy to rebase [1] on your series, or the other way around,
whichever is easier.

[1] https://lore.kernel.org/20261105164856.29698-1-parri.andrea@xxxxxxxxx/
[2] https://lore.kernel.org/94d8d7af-b04f-4c59-ae3b-e693d4457a65@xxxxxxxxxxxx/

Thanks,
Andrea