Re: [PATCH v6 0/8] iio: imu: Add support for the ADI ADIS16607
From: Andy Shevchenko
Date: Fri Nov 13 2026 - 14:49:59 EST
On Fri, Nov 13, 2026 at 12:41:04PM +0000, Sabau, Radu bogdan wrote:
> > -----Original Message-----
> > From: Radu Sabau via B4 Relay <devnull+radu.sabau.analog.com@xxxxxxxxxx>
> > Sent: Friday, November 13, 2026 2:34 PM
...
> > Patches 5-8 add the driver in functional groupings, as requested in
> > v1 review:
> > - Patch 5: base driver - probe, raw channel reads, decimation/sample
> > frequency, startup and self-test via adislib, debugfs identity
> > entries. No buffered capture yet.
> > - Patch 6: buffered capture via the device's hardware FIFO, into a
> > kfifo buffer filled from a threaded interrupt (no IIO trigger).
>
> Note: this series implements the FIFO buffered capture with a kfifo
> buffer for the adis16607 only, using its own threaded interrupt instead
> of adislib's has_fifo trigger path. I tested it on hardware and it
> behaves better than the trigger-based version in v5: the interrupt now
> fires once per watermark batch instead of roughly once per sample, and
> capture stays clean across repeated buffer enable/disable cycles.
>
> I plan a follow-up series that updates adislib and the other affected
> devices (the adis16475 FIFO variants) to use a kfifo buffer as well, and
> then converts this driver to use the adislib helpers.
>
> If you would rather have it handled here, I can instead do the adislib
> and adis16475 changes in this series, as patches ahead of the driver.
As you explained above I think the proper change is update the library followed
by the driver.
--
With Best Regards,
Andy Shevchenko