Re: [PATCH 1/3] dt-bindings: add STM32MP21 regulator bindings

[Conor Dooley]

On Fri, Nov 13, 2026 at 03:10:39PM +0100, Patrick Delaunay wrote:
> These bindings will be used for the SCMI voltage domain.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@xxxxxxxxxxx>

I don't believe these are bindings at all. Where is your software that
is using it?
They're no more bindings that interrupt numbers are, since they're
defined by the firmware, rather than what binding headers are normally
for: inventing meaning for numbers so that we can have an ABI.
These numbers arent even fixed, changing the firmware can change what
regulator these IDs represent, although anyone who would do that should
probably be taken around back.

IMO, if you want these definitions for your dts, move the header to the
dts directory.
pw-bot: changes-requested

Thanks,
Conor.

> ---
> 
>  .../regulator/st,stm32mp21-regulator.h        | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 include/dt-bindings/regulator/st,stm32mp21-regulator.h
> 
> diff --git a/include/dt-bindings/regulator/st,stm32mp21-regulator.h b/include/dt-bindings/regulator/st,stm32mp21-regulator.h
> new file mode 100644
> index 000000000000..fcafcfb6dc54
> --- /dev/null
> +++ b/include/dt-bindings/regulator/st,stm32mp21-regulator.h
> @@ -0,0 +1,48 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
> +/*
> + * Copyright (C) 2026, STMicroelectronics - All Rights Reserved
> + */
> +
> +#ifndef __DT_BINDINGS_REGULATOR_ST_STM32MP21_REGULATOR_H
> +#define __DT_BINDINGS_REGULATOR_ST_STM32MP21_REGULATOR_H
> +
> +/* SCMI voltage domains identifiers */
> +
> +/* SOC Internal regulators */
> +#define VOLTD_SCMI_VDDIO1		0
> +#define VOLTD_SCMI_VDDIO2		1
> +#define VOLTD_SCMI_VDDIO3		2
> +#define VOLTD_SCMI_ADC			3
> +#define VOLTD_SCMI_VREFBUF		4
> +
> +/* STPMIC regulators (STPMIC25/STM32MP2L/STPMIC1L) */
> +#define VOLTD_SCMI_STPMIC_BUCK1		5
> +#define VOLTD_SCMI_STPMIC_BUCK2		6
> +#define VOLTD_SCMI_STPMIC_BUCK3		7
> +#define VOLTD_SCMI_STPMIC_BUCK4		8
> +#define VOLTD_SCMI_STPMIC_BUCK5		9
> +#define VOLTD_SCMI_STPMIC_BUCK6		10
> +#define VOLTD_SCMI_STPMIC_BUCK7		11
> +#define VOLTD_SCMI_STPMIC_LDO1		12
> +#define VOLTD_SCMI_STPMIC_LDO2		13
> +#define VOLTD_SCMI_STPMIC_LDO3		14
> +#define VOLTD_SCMI_STPMIC_LDO4		15
> +#define VOLTD_SCMI_STPMIC_LDO5		16
> +#define VOLTD_SCMI_STPMIC_LDO6		17
> +#define VOLTD_SCMI_STPMIC_LDO7		18
> +#define VOLTD_SCMI_STPMIC_LDO8		19
> +#define VOLTD_SCMI_STPMIC_REFDDR	20
> +#define VOLTD_SCMI_STPMIC_GPO1		21
> +#define VOLTD_SCMI_STPMIC_GPO2		22
> +#define VOLTD_SCMI_STPMIC_GPO3		23
> +#define VOLTD_SCMI_STPMIC_GPO4		24
> +#define VOLTD_SCMI_STPMIC_GPO5		25
> +
> +/* External regulators */
> +#define VOLTD_SCMI_REGU0		26
> +#define VOLTD_SCMI_REGU1		27
> +#define VOLTD_SCMI_REGU2		28
> +#define VOLTD_SCMI_REGU3		29
> +#define VOLTD_SCMI_REGU4		30
> +
> +#endif /*__DT_BINDINGS_REGULATOR_ST_STM32MP21_REGULATOR_H */
> -- 
> 2.43.0
>

Attachment: signature.asc
Description: PGP signature