Re: [PATCH v9 05/12] nvmem: Add the Raspberry Pi OTP driver

From: Florian Fainelli

Date: Fri Nov 13 2026 - 16:16:51 EST


On 11/12/26 22:34, Uwe Kleine-König wrote:
Hello

[dropped Ray Jui and Scott Branden from Cc: as their addresses don't
seem to exist any more]

Their emails are still valid, they just moved to first.lastname@xxxxxxxxxxxx, reminds me I need to send Jiri's patch correcting that.


On Wed, Nov 11, 2026 at 08:23:27AM +0100, Gregor Herburger wrote:
+#include <linux/mod_devicetable.h>
[...]
+#include <linux/platform_device.h>

Don't include <linux/mod_devicetable.h> as that introduces a lot of
unneeded build dependencies. <linux/platform_device.h> is sufficient to
get of_device_id, so you can just drop <linux/mod_devicetable.h>.

[...]
+static struct platform_driver raspberrypi_otp_driver = {
+ .probe = rpi_otp_probe,
+ .driver = {
+ .name = "raspberrypi-otp",
+ },
+ .id_table = raspberrypi_otp_id,
+};

Inconsistent use of spacing before =. If you ask me everything other than
a single space gets inconsistent over time, so I recommend sticking to
that.

Best regards
Uwe


--
Florian