Re: [PATCH v2 3/9] drm/rockchip: vop2: Fix the HDMI sync polarity on RK3588
From: Arun Iyengar
Date: Fri Nov 13 2026 - 16:41:05 EST
Hi Damon, Chaoyi,
The TRM names GRF_VO1_CON0 bit 5 the HDMI0 vsync polarity and bit 6
hsync (7 and 8 for HDMI1); the driver, like the vendor kernel, uses
them the other way round.
The HDMI controller agrees with the TRM. With patch 3 and 1920x1080@144
+HSync -VSync the driver sets bit 6, and VIDEO_INTERFACE_STATUS0 reports
-HSync +VSync; with 1600x1280@60 -HSync +VSync it sets bit 5 and the
controller sees +HSync -VSync.
v3 keeps patch 3 as you reviewed it and adds patch 4, which swaps the
two bits; with it the controller reports both modes as set. Please
shout if the TRM is wrong here.
v3 4/8: https://lore.kernel.org/r/20261113-vop2-fixes-v3-4-08ae37e83b5c@xxxxxxxxx
Best regards,
Arun