Re: [PATCH v2 0/11] perf coverage: A harness for perf, and the fixes it found
From: Ian Rogers
Date: Fri Nov 13 2026 - 17:21:21 EST
On Fri, Nov 13, 2026 at 12:08 PM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
> Hi,
>
> Please consider merging,
>
> Nothing measured how much of perf the test suite reaches. Patch 1 adds
> tools/perf/scripts/coverage.sh: it builds perf with clang source based
> coverage, runs the complete perf test suite and reports line and function
> coverage, optionally against a baseline, with --table and --html like
> pahole's coverage_table.py. Also as 'make -C tools/perf coverage',
> 'coverage-prep' and 'coverage-table'.
>
> The rest is what the first runs found, in the code, the build and the
> tests:
>
> - clang DWARF 5 describes globals with DW_OP_addrx, which was not
> resolved (patch 2).
> - The flexible array member had no test; one showed the struct row at
> 0.00% while the member said 100.00% (patches 3-4).
> - A struct pointer that -O2 keeps in a register was not resolved from
> its DWARF location (patch 5).
> - --insn-stat was printed before the loop that accounts the samples,
> so --code-with-type showed zeros (patch 6).
> - The libbfd probe printed a missing bfd.h error five times per
> build-test run (patch 7).
> - FEATURE-DUMP didn't record llvm-perf and rust, disabling both in the
> build-test builds (patch 8).
> - The Intel PT virtual LBR check lost every aux sample with a single
> data page (patch 9).
> - The dlfilter test kept samples whose IP the kernel now zeroes on a
> userspace-to-kernel skid (patch 10).
> - The LBR inline unwinding check failed instead of skipping when the
> AMD PMU rejects branch sampling (patch 11).
>
> In a root run on this box the suite covered 49.16% of perf's 201,180
> lines. The POLL_HUP tracepoint regression and the lock contention count
> fail in code this series does not change; the LBR inline unwinding check
> failed there and now skips.
>
> The numbers above are from v1 and are slightly different here: the
> cs-etm patch was dropped and the issues reported in the v1 review were
> addressed, which changes both the tree and what the report counts.
>
> The harness and the tests were developed with an AI coding assistant
> (OpenCode), which drafted the script and the tests and helped debug the
> failures; I reviewed every change and reproduced each failure before
> fixing it.
>
> What changed from v1:
>
> - Patch 9 (cs-etm) is gone: Leo Yan's series replaces it.
> - Patch 1: O= is accepted by all targets, the Python extension is in
> the report, -f is normalized and the delta matches its baseline.
> - Patch 4: the TUI browser counts flexible array accesses too.
> - Patch 6: the stats test skips without libdw.
> - Patches 9 and 11 (were 10 and 12): Fixes tags corrected.
>
> Best regards,
>
> - Arnaldo
>
> Arnaldo Carvalho de Melo (11):
> perf scripts: Add a coverage harness for perf
> perf annotate-data: Resolve DW_OP_addrx global variables
> perf tests: Exercise the flexible array member path
> perf annotate-data: Count flexible array accesses for the whole struct
> perf tests: Exercise data type resolution from a register
> perf annotate: Print the stats after the annotations
> perf tests: Silence the libbfd probe in build-test
> perf build: Record the display-only features in FEATURE-DUMP
> perf tests: Fix the Intel PT virtual LBR check
> perf test: Drop samples without an IP in the dlfilter test
> perf test: Skip the LBR inline unwinding check when unsupported
Thanks for working on this! Patches 2, 3 and 5 add small C programs
compiled in a shell test. These are a pain for our CI framework; could
we add them as perf test workloads?
Thanks,
Ian
> tools/perf/.gitignore | 1 +
> tools/perf/Makefile | 11 +-
> tools/perf/Makefile.config | 4 +
> tools/perf/Makefile.perf | 4 +
> tools/perf/builtin-annotate.c | 10 +-
> tools/perf/scripts/coverage.sh | 722 ++++++++++++++++++
> tools/perf/tests/make | 2 +-
> tools/perf/tests/shell/addr2line_inlines.sh | 9 +-
> tools/perf/tests/shell/annotate_stats.sh | 64 ++
> .../perf/tests/shell/data_type_flex_array.sh | 142 ++++
> .../tests/shell/data_type_profiling_clang.sh | 108 +++
> tools/perf/tests/shell/data_type_register.sh | 120 +++
> tools/perf/tests/shell/script_dlfilter.sh | 2 +-
> tools/perf/tests/shell/test_intel_pt.sh | 9 +-
> tools/perf/ui/browsers/annotate-data.c | 7 +-
> tools/perf/util/annotate-data.c | 24 +-
> tools/perf/util/annotate-data.h | 3 +
> tools/perf/util/dwarf-aux.c | 42 +-
> 18 files changed, 1260 insertions(+), 24 deletions(-)
> create mode 100755 tools/perf/scripts/coverage.sh
> create mode 100755 tools/perf/tests/shell/annotate_stats.sh
> create mode 100755 tools/perf/tests/shell/data_type_flex_array.sh
> create mode 100755 tools/perf/tests/shell/data_type_profiling_clang.sh
> create mode 100755 tools/perf/tests/shell/data_type_register.sh
>
>
> base-commit: cc905a18a647a8e3ad42cd1596baa0e08fba26eb
> v1-head: 3f5465bea8f5a97a
> --
> 2.56.0
>