Re: [PATCH v4 25/25] dmaengine: sdxi: Add DMA engine provider
From: Lynch, Nathan
Date: Fri Nov 13 2026 - 18:36:29 EST
On 11/13/2026 11:50 AM, Frank Li wrote:
> On Tue, Nov 03, 2026 at 08:50:06PM -0600, Nathan Lynch wrote:
>> +static void sdxi_dma_issue_pending(struct dma_chan *dma_chan)
>> +{
>> + struct sdxi_dma_chan *sdchan = to_sdxi_dma_chan(dma_chan);
>> +
>> + guard(spinlock_irqsave)(&sdchan->vchan.lock);
>> +
>> + list_splice_tail_init(&sdchan->vchan.desc_submitted, &sdchan->pending);
>
> why not use vchan's desc_issued?
Among issued transactions, the driver needs to distinguish between those
that have actually published descriptors to the ring and those that are
still waiting for room. So it uses this driver-internal pending list for
txds that are waiting and only moves them to vchan->desc_issued once
they have live descriptors.
But I'll look into eliminating the extra list, it looks doable.