Re: [PATCH v2 2/6] firmware: qcom_scm: Transition to ICE TZ agnostic operations
From: Eric Biggers
Date: Fri Nov 13 2026 - 19:22:27 EST
On Wed, Nov 11, 2026 at 07:47:02PM +0530, Harshal Dev wrote:
> Transition the ICE related SCM calls to the generic ICE TZ operations by
> registering them with the ICE driver and wrapping them in exported APIs
> with the same signature.
>
> This prepares the ICE driver for eventual migration to the TZ agnostic
> secure programming interfaces once the TEE bus based back-end becomes
> available.
>
> Signed-off-by: Harshal Dev <harshal.dev@xxxxxxxxxxxxxxxx>
> ---
> drivers/firmware/qcom/qcom_scm.c | 131 +++++++++++++++++++++++++++++++--------
> 1 file changed, 106 insertions(+), 25 deletions(-)
Wouldn't it make more sense to leave qcom_scm alone, and have qcom_ice
decide whether it should call qcom_scm_ice_*() or the OP-TEE backend?
That would avoid the circular dependency between qcom_scm and qcom_ice
which this patch introduces, and eliminate the need for patches 2 and 6.
- Eric