Re: [PATCH net-next v4 1/3] ethtool: add PHY receive frame and byte totals

From: Andrew Lunn

Date: Fri Nov 13 2026 - 19:23:38 EST


> Correct the documented group name to
> phydev, matching the existing name exported by the kernel.

> +++ b/Documentation/networking/ethtool-netlink.rst
> @@ -1665,7 +1665,7 @@ the ``ETHTOOL_A_STATS_GROUPS`` bitset. Currently defined values are:
> ETHTOOL_STATS_ETH_PHY eth-phy Basic IEEE 802.3 PHY statistics (30.3.2.1.*)
> ETHTOOL_STATS_ETH_CTRL eth-ctrl Basic IEEE 802.3 MAC Ctrl statistics (30.3.3.*)
> ETHTOOL_STATS_RMON rmon RMON (RFC 2819) statistics
> - ETHTOOL_STATS_PHY phy Additional PHY statistics, not defined by IEEE
> + ETHTOOL_STATS_PHY phydev Additional PHY statistics, not defined by IEEE
> ====================== ======== ===============================================
>
> Each group should have a corresponding ``ETHTOOL_A_STATS_GRP`` in the reply.

This should be a patch of its own. That would of forced you to write a
useful commit message, and i would not of needed to ask why it
changed.

You want lots of small patches, with good commit messages, which are
obviously correct.

I suggest you spend some time reviewing other developers patches. See
it from the other side.

Andrew

---
pw-bot: cr