Re: [PATCH v2] lib/crc: arm64: use .arch_extension to enable CRC and crypto
From: Eric Biggers
Date: Fri Nov 13 2026 - 23:31:10 EST
On Wed, Nov 11, 2026 at 03:25:56PM +0100, Emanuele Rocca wrote:
> Use .arch_extension instead of .arch and .cpu in crc32-core.S and
> crc-t10dif-core.S.
>
> .arch and .cpu reset the assembler's feature set, dropping extensions
> enabled via -march. See commit 9142c2f8f84b ("octeontx2: use
> arch_extension to enable LSE"), where this caused an actual build
> failure.
>
> That is not a problem here: the instructions these files use are all
> covered by the CRC and crypto extensions. Switch anyway for consistency
> and to avoid surprises if the files later use instructions outside
> generic+crc+crypto.
>
> .arch_extension is supported by binutils since 2.26 and by clang since
> 8.0.0, both older than the minimum versions currently required to build
> the kernel (2.30 and 17.0.1 respectively).
>
> Signed-off-by: Emanuele Rocca <emanuele.rocca@xxxxxxx>
> ---
> Changes in v2:
> - Update crc-t10dif-core.S in addition to crc32-core.S
> - Clarify in commit message that this is not a functional change
>
> Link to v1:
> https://lore.kernel.org/all/20261105154145.557042-1-emanuele.rocca@xxxxxxx/
> ---
> lib/crc/arm64/crc-t10dif-core.S | 2 +-
> lib/crc/arm64/crc32-core.S | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next
- Eric