Re: [PATCH] staging: greybus: audio_manager: add newline to sysfs_emit formats
From: Dan Carpenter
Date: Sat Nov 14 2026 - 00:04:06 EST
On Fri, Nov 13, 2026 at 06:33:24PM +0530, Rishiraj Rajgor wrote:
> According to sysfs guidelines and checkpatch SYSFS_EMIT rule, sysfs
> show functions should terminate outputs with a newline. The show
> functions in audio_manager_module.c omit the newline character from
> their sysfs_emit() format strings.
>
> Add a terminating newline to all sysfs_emit() format strings in
> gb_audio_module_*_show() functions.
>
> Signed-off-by: Rishiraj Rajgor <rishirajrajgor@xxxxxxxxx>
> ---
No, see the mail archives for why.
regards,
dan carpenter