[PATCH 3/5] platform/x86: dell: dcdbas: Release the SMI buffer in remove
From: Rosen Penev
Date: Sat Nov 14 2026 - 01:18:53 EST
dcdbas_exit() frees the SMI data buffer before
platform_device_unregister() removes the sysfs attributes, and without
holding smi_data_lock. The comment claims that only at module exit can
all sysfs attributes be released, but device attributes do not pin the
module: while rmmod runs, smi_data_write() or smi_data_buf_size_store()
can still be executing. They can then memcpy() into the buffer as it is
freed, or allocate a new buffer that is never freed.
sysfs_remove_group() in dcdbas_remove() waits for running attribute
handlers, and dcdbas_pdev is still valid at that point. Free the buffer
there, or unmap the firmware-provided buffer when WSMT is in use, and
also do it when probe fails after dcdbas_check_wsmt() mapped the
firmware buffer. Reset the WSMT state with it so a later probe starts
clean.
Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
---
drivers/platform/x86/dell/dcdbas.c | 46 ++++++++++++++++++------------
1 file changed, 28 insertions(+), 18 deletions(-)
diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c
index 601ee8ca92e4..d5a93aca9c93 100644
--- a/drivers/platform/x86/dell/dcdbas.c
+++ b/drivers/platform/x86/dell/dcdbas.c
@@ -98,6 +98,22 @@ static void smi_data_buf_free(void)
dcdbas_smi_free(&smi_buf);
}
+/**
+ * dcdbas_release_buffer: free the SMI data buffer or unmap the WSMT one
+ */
+static void dcdbas_release_buffer(void)
+{
+ if (wsmt_enabled) {
+ memunmap(bios_buffer);
+ bios_buffer = NULL;
+ smi_buf = (struct smi_buffer){};
+ max_smi_data_buf_size = MAX_SMI_DATA_BUF_SIZE;
+ wsmt_enabled = false;
+ } else {
+ smi_data_buf_free();
+ }
+}
+
/**
* smi_data_buf_realloc: grow SMI data buffer if needed
*/
@@ -685,11 +701,11 @@ static int dcdbas_probe(struct platform_device *dev)
*/
error = dma_set_coherent_mask(&dcdbas_pdev->dev, DMA_BIT_MASK(32));
if (error)
- return error;
+ goto err_release_buffer;
error = sysfs_create_group(&dev->dev.kobj, &dcdbas_attr_group);
if (error)
- return error;
+ goto err_release_buffer;
register_reboot_notifier(&dcdbas_reboot_nb);
@@ -697,12 +713,22 @@ static int dcdbas_probe(struct platform_device *dev)
DRIVER_DESCRIPTION, DRIVER_VERSION);
return 0;
+
+err_release_buffer:
+ dcdbas_release_buffer();
+ return error;
}
static void dcdbas_remove(struct platform_device *dev)
{
unregister_reboot_notifier(&dcdbas_reboot_nb);
sysfs_remove_group(&dev->dev.kobj, &dcdbas_attr_group);
+
+ /*
+ * sysfs_remove_group() waited for any attribute handler still
+ * running, so nothing else uses the buffer now.
+ */
+ dcdbas_release_buffer();
}
static struct platform_driver dcdbas_driver = {
@@ -751,22 +777,6 @@ static int __init dcdbas_init(void)
*/
static void __exit dcdbas_exit(void)
{
- /*
- * make sure functions that use dcdbas_pdev are called
- * before platform_device_unregister
- */
- unregister_reboot_notifier(&dcdbas_reboot_nb);
-
- /*
- * We have to free the buffer here instead of dcdbas_remove
- * because only in module exit function we can be sure that
- * all sysfs attributes belonging to this module have been
- * released.
- */
- if (dcdbas_pdev)
- smi_data_buf_free();
- if (bios_buffer)
- memunmap(bios_buffer);
platform_device_unregister(dcdbas_pdev_reg);
platform_driver_unregister(&dcdbas_driver);
}
--
2.56.0