Re: [PATCH net v2 1/2] af_unix: Fix scm_stat.nr_fds leak in unix_dgram_disconnected().

From: Kuniyuki Iwashima

Date: Sat Nov 14 2026 - 02:33:32 EST


On Wed, 11 Nov 2026 22:51:47 +0000, Siddharth Chintamaneni wrote:
> When a connected SOCK_DGRAM socket disconnects (e.g. via connect() with
> AF_UNSPEC), reconnects to a different peer, or observes a dead peer in
> unix_dgram_sendmsg(), unix_dgram_disconnected() purges all unread
> datagrams from sk->sk_receive_queue via skb_queue_purge_reason().
>
> Because skb_queue_purge_reason() frees each skb without calling
> scm_stat_del(sk, skb), any SCM_RIGHTS file descriptors attached to the
> purged skbs remain permanently accounted in u->scm_stat.nr_fds (reported
> as scm_fds in /proc/<pid>/fdinfo/<fd>) for the remaining lifetime of the
> socket.
>
> Move scm_stat_add() and scm_stat_del() above unix_dgram_disconnected(),
> splice sk->sk_receive_queue onto a local list under the queue lock, and
> call scm_stat_del() before kfree_skb_reason() on each purged skb.
>
> Fixes: 3c32da19a858 ("unix: Show number of pending scm files of receive queue in fdinfo")
> Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@xxxxxxxxx>

Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>