Re: [PATCH v3 2/2] power: supply: Add Qualcomm SMB1351 charger driver
From: Markus Elfring
Date: Sat Nov 14 2026 - 06:39:40 EST
…
> +++ b/drivers/power/supply/qcom_smb1351.c
> @@ -0,0 +1,439 @@
…
> +static void smb1351_external_power_changed(struct power_supply *psy)
> +{
…
> + spin_lock(&chip->lock);
> + WRITE_ONCE(chip->retry_until,
> + jiffies + msecs_to_jiffies(SMB1351_SETTLE_MS +
> + SMB1351_RETRY_TIMEOUT_MS));
> + mod_delayed_work(system_freezable_wq, &chip->work,
> + msecs_to_jiffies(SMB1351_SETTLE_MS));
> + spin_unlock(&chip->lock);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock)(&chip->lock);”?
https://elixir.bootlin.com/linux/v7.3.1/source/include/linux/spinlock.h#L610-L612
Regards,
Markus