Re: [PATCH net-next 2/3] net: phy: dap8211r: add extended register write helper

[Artem Shimko]

Hi Andrew,

On Fri, Nov 13, 2026 at 11:28 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > + * The caller must hold the MDIO bus lock.
> > + *
> > + * Return: 0 on success, or negative error code
> > + */
> > +static int dap8211r_write_ext(struct phy_device *phydev, u16 reg, u16 data)
> > +{
> > +     int ret;
> > +
> > +     phy_lock_mdio_bus(phydev);
>
> How does this not deadlock, if the caller is already holding the MDIO
> bus lock, as commented on above?

The comment is wrong, my bad, all three helpers (read_ext, write_ext,
modify_ext) take the MDIO bus lock internally.
There is the same mistake in the comments of read_ext() and
modify_ext(), so I will fix all three in v2.

Thank you.

Best regards,
artem