Re: [PATCH v4 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc
From: Matti Vaittinen
Date: Sat Nov 14 2026 - 08:48:42 EST
On 13/11/2026 18:25, Maxime Chevallier wrote:
Hi Matti,
On 11/13/26 16:36, Matti Vaittinen wrote:
On 13/11/2026 17:15, Maxime Chevallier wrote:
Add a new driver for the TI TLA2528 ADC chip. It has 8 12-bitThis looks very familiar to me. I am pretty sure I've reviewed this. Is there a reason the RB-tag wasn't carried over? (Sorry if I've missed some change(s))!
channels, that can also be configured as 16-bit averaging channels.
This is a very simple driver, allowing reading raw values for each
channel. GPIO mode isn't supported for now, as well as buffered mode and
the 16-bit averaging mode.
Co-developed-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
Signed-off-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
Signed-off-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
Yours,
-- Matti
You did add a Rb tag on V2, but I dropped it for V3 as the delta between V2
and V3 was quite substantial and included changes requested by other people
than you :)
Ok. Thanks for the explanation.
I mentionned your tag being dropped on the V3 cover, but I didn't carry that info
for V4, sorry about that...
Keeping the note in the cover version history can indeed help reviewers.
Anyways thanks a lot for the help,
No problem. It looks like a clean and nice driver to me. Good job.
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~