Re: [PATCH net-next 3/3] net: phy: dap8211r: add led hardware control support
From: Artem Shimko
Date: Sat Nov 14 2026 - 10:33:15 EST
Hi Andrew,
On Sat, Nov 14, 2026 at 6:13 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > The LED_COMCON register does include "force-on/force-off" bits,
> > but i have intentionally chosen not to use them here.
> > To be honest, i’m not yet convinced that they need to be added.
>
> They allow you to implement set_brightness. That is ideally the base
> for all LEDs, being able to turn them on/off. If you can do that, all
> the trigger can work with software driving the LEDs. You can show the
> heartbeat, shift-lock, and all networking settings.
>
> Making use of the hardware to blink on network activity is an optional
> extra, reduced the CPU load etc, but just nice to have.
I got it, thanks for the clarification, will do.
Best regards,
artem