Re: [PATCH] hwmon: (nct6683) Add customer ID for ASRock X600DC-ITX
From: Guenter Roeck
Date: Sat Nov 14 2026 - 11:40:55 EST
On Sat, Nov 14, 2026 at 08:37:11PM +1100, Samuel Herdman wrote:
> From: Samuel Herdman <lk.gzpc0@xxxxxxxxxxxx>
>
> The ASRock X600DC-ITX (BIOS 2.02) has an NCT6686D with customer ID
> 0x165f, which the driver does not know, so it only binds with force=1:
>
> nct6683: Found NCT6686D or compatible chip at 0x2e:0xa20
> nct6683 nct6683.2592: Enabling support for unknown customer ID 0x165f
> nct6683 nct6683.2592: NCT6686D EC firmware version 1.0 build 12/23/25
>
> The change:
>
> Add the customer ID so the driver binds on this board without force=1,
> and add the board to the list of tested boards.
>
> Tests:
>
> - With force=1 the readings are plausible: the CPU temperature (AMD TSI
> Addr 98h) is within a few degrees of k10temp's Tctl, VCC, VSB and
> AVSB read 3.36 V, VBAT reads 3.2 V, and fan1 reads about 1450 RPM.
> - With the same change applied to v7.3.3 on this board, the driver
> binds without force=1 and reports temperature and fan readings.
>
> The patch and this changelog were drafted with an AI coding assistant
> (Claude Code); I reviewed them and ran the tests above on my board.
>
> Signed-off-by: Samuel Herdman <lk.gzpc0@xxxxxxxxxxxx>
> ---
> This overlaps with Johan Dahlin's pending series "hwmon: (nct6683) Fan
> control and sensor names for ASRock NCT6686D boards" (v2, 11 Nov 2026).
> Its first patch also adds NCT6683_CUSTOMER_ID_ASROCK8 (0x164a) and a
> table row at the same spot, and its later patches key fan control on
> that macro. Whichever lands second needs its macro renumbered
> throughout; I'm happy to rebase on top of that series if preferred.
Applied, fixed conflicts. Thanks a lot for letting me know.
Guenter