Re: [PATCH 2/6] watchdog: tegra_wdt: Move SoC specific parts into match data
From: Guenter Roeck
Date: Sat Nov 14 2026 - 12:22:56 EST
On Tue, Nov 10, 2026 at 01:39:07PM +0100, Artur Kowalski wrote:
> The driver only supports the watchdog blocks of Tegra30 and later. Move
> the parts that differ between SoC generations, namely the watchdog
> operations, the maximum timeout and the register setup, into a per-SoC
> structure selected through the match data, so that support for Tegra20,
> which has no watchdog block, can be added.
This does not make sense. Literally every watchdog operation is different.
Tegra 20 support should be added with a separate driver.
>
> Suspend and resume call the operations through the watchdog device, so
> they work with any SoC.
>
> No functional change.
>
> Assisted-by: Claude:claude-opus-5-5
This trailer is obsolete. Please have your agent follow AGENTS.md.
Thanks,
Guenter