Re: [PATCH v2 0/4] This series adds support for Texas Instruments OPT4041 Ambient light sensor

From: Jonathan Cameron

Date: Sat Nov 14 2026 - 13:42:14 EST


On Tue, 10 Nov 2026 17:08:38 +0100
Jesper X Nilsson <jesperni@xxxxxxxx> wrote:

> On 10/23/26 22:58, Jonathan Cameron wrote:
> > On Fri, 23 Oct 2026 14:30:27 +0200
> > Jesper X Nilsson <jesper.x.nilsson@xxxxxxxx> wrote:
> >
> >> Extend the opt4001 driver to support OPT4041, since it is so similar to
> >> OPT4001. The OPT4041 adds a second channel, a wide band channel ranging
> >> from 380nm to 1000nm. The register map is almost the same for both
> >> devices. OPT4001 has an internal fifo of size four, OPT4041 has two
> >> fifos of size two, one for each channel.
> >>
> >> Since OPT4041 has two channels it has one bit in register 0Bh to select
> >> which channel is compared to the threshold register. The driver does not
> >> support setting the threshold registers, so no new support has been
> >> added for this.
> >>
> >> The OPT4041 is pin compatible and has the same package as
> >> opt4001-sot-5x3. Although the device id is different, I added a new
> >> compatible string since the driver already had different compatible
> >> strings to differentiate between the two OPT4001.
> >>
> >> Datasheet: https://www.ti.com/lit/gpn/opt4041
> >> Signed-off-by: Jesper X Nilsson <jesper.x.nilsson@xxxxxxxx>
> >
> >
> > Normally I'd say slow down to give more time for review, but seems
> > you got good reviews anyway and the code looks clean to me.
> >
> > Ah well, sometimes you win - but generally wait a few days at lesat
> > between versions.
> >
> I will keep that in mind. Since I got good comments so fast, I was eager
> to fix them.
>
> > Applied to the testing branch of iio.git. I'll be rebasing that
> > on rc1 once available.
> >
> Have the changes been applied? I can not see them on the testing branch
> of iio.git
>
I clearly messed something up because indeed they aren't there.

Sorry about that. Now actually applied and pushed out on the testing branch.


> Best regards,
> Jesper
>
> > thanks,
> >
> > Jonathan
>