Re: [PATCH v6 10/11] iio: adc: ti-ads1015: inline ads1015_set_conv_mode()

From: Jonathan Cameron

Date: Sat Nov 14 2026 - 19:17:05 EST


On Mon, 9 Nov 2026 22:28:04 +0530
Archit Anant <architanant5@xxxxxxxxx> wrote:

> The ads1015_set_conv_mode() helper function is a single-line wrapper
> around regmap_update_bits().
>
> Since the function is simple and only called during initialization and
> power management state transitions, the wrapper is unnecessary. Remove
> it and inline the regmap_update_bits() logic directly at the call sites
> to improve code readability and traceabilty.
>
> Where applicable, introduce a local 'map' pointer to keep the
> inlined function calls concise.
>
> Suggested-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> Signed-off-by: Archit Anant <architanant5@xxxxxxxxx>
> ---
> drivers/iio/adc/ti-ads1015.c | 32 +++++++++++++++++---------------
> 1 file changed, 17 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> index 93a8318e950e2..2c3ba1b91aac4 100644
> --- a/drivers/iio/adc/ti-ads1015.c
> +++ b/drivers/iio/adc/ti-ads1015.c

...

> @@ -956,6 +951,7 @@ static int ads1015_probe(struct i2c_client *client)
> struct device *dev = &client->dev;
> struct iio_dev *indio_dev;
> struct ads1015_data *data;
> + struct regmap *map;
> int ret;
> int i;
>
> @@ -1007,8 +1003,9 @@ static int ads1015_probe(struct i2c_client *client)
> data->regmap = devm_regmap_init_i2c(client, chip->has_comparator ?
> &ads1015_regmap_config :
> &tla2024_regmap_config);
> - if (IS_ERR(data->regmap))
> - return dev_err_probe(dev, PTR_ERR(data->regmap),
> + map = data->regmap;

Where it is easy enough to do, don't put error pointers into structures.
So

map = devm_regmap_init_i2c();
if (IS_ERR(map))
return dev_err_probe(dev, PTR_ERR(map),
"Failed to allocate register map\n");

data->regmap = map;

I'm not advocating whole scale cleanup of other drivers for this
as it is churn heavy but here it makes the code you are changing
anyway better.

> + if (IS_ERR(map))
> + return dev_err_probe(dev, PTR_ERR(map),
> "Failed to allocate register map\n");
>
> ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,