[PATCH net-next v2] NFC: digital: fix target leak after Type 1 Tag discovery

From: Xia Yan

Date: Sat Nov 14 2026 - 20:25:06 EST


digital_in_recv_sens_res() allocates a target for an NFC-A response.
For a Type 1 Tag, it calls digital_target_found() synchronously.
nfc_targets_found() copies the target into dev->targets.

On success, rc is zero and the callback skips kfree(target).
The original allocation is lost when the callback returns.
Each completed Type 1 Tag discovery leaks one struct nfc_target.

Free the target on the exit path, also for a Type 1 Tag:
digital_target_found() does not take ownership of the target. Keep the
target for other tag types, whose discovery continues asynchronously.

Found during a code review of NFC-A target ownership.

Fixes: 2c66daecc409 ("NFC Digital: Add NFC-A technology support")
Suggested-by: Simon Horman <horms@xxxxxxxxxx>
Signed-off-by: Xia Yan <yanxia@xxxxxxxxxxxxxxxxxxxx>
---
Changes in v2:
- Free the target on the exit path and add a comment on target
ownership, as suggested by Simon Horman.

v1: https://lore.kernel.org/netdev/20261109031832.37642-1-yanxia@xxxxxxxxxxxxxxxxxxxx/

net/nfc/digital_technology.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/net/nfc/digital_technology.c b/net/nfc/digital_technology.c
index ae6487c10a25..62d385a49685 100644
--- a/net/nfc/digital_technology.c
+++ b/net/nfc/digital_technology.c
@@ -483,6 +483,7 @@ static void digital_in_recv_sens_res(struct nfc_digital_dev *ddev, void *arg,
struct sk_buff *resp)
{
struct nfc_target *target = NULL;
+ bool res_is_t1t = false;
int rc;

if (IS_ERR(resp)) {
@@ -510,7 +511,8 @@ static void digital_in_recv_sens_res(struct nfc_digital_dev *ddev, void *arg,
goto exit;
}

- if (DIGITAL_SENS_RES_IS_T1T(target->sens_res))
+ res_is_t1t = DIGITAL_SENS_RES_IS_T1T(target->sens_res);
+ if (res_is_t1t)
rc = digital_target_found(ddev, target, NFC_PROTO_JEWEL);
else
rc = digital_in_send_sdd_req(ddev, target);
@@ -518,10 +520,15 @@ static void digital_in_recv_sens_res(struct nfc_digital_dev *ddev, void *arg,
exit:
dev_kfree_skb(resp);

- if (rc) {
+ /* Release target on error.
+ * digital_target_found() does not take ownership of target,
+ * so also release target if res_is_t1t is true.
+ */
+ if (rc || res_is_t1t)
kfree(target);
+
+ if (rc)
digital_poll_next_tech(ddev);
- }
}

int digital_in_send_sens_req(struct nfc_digital_dev *ddev, u8 rf_tech)