[PATCH] hwmon: (pmbus/xdp710) Use dev_err_probe()
From: Niloy Meharchandani
Date: Sat Nov 14 2026 - 21:21:27 EST
Use dev_err_probe() in xdp710_probe() instead of dev_err() followed by
returning the error. This simplifies the error paths and prints the error
code in symbolic form.
No functional change intended. Compile-tested only.
Signed-off-by: Niloy Meharchandani <niloymeharchandani@xxxxxxxxx>
---
drivers/hwmon/pmbus/xdp710.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/hwmon/pmbus/xdp710.c b/drivers/hwmon/pmbus/xdp710.c
index 494dbe45ebc6..34c6cefbfc13 100644
--- a/drivers/hwmon/pmbus/xdp710.c
+++ b/drivers/hwmon/pmbus/xdp710.c
@@ -71,24 +71,18 @@ static int xdp710_probe(struct i2c_client *client)
return -ENOMEM;
ret = i2c_smbus_read_word_data(client, XDP710_CS_RNG);
- if (ret < 0) {
- dev_err(&client->dev, "Can't get CS_RNG");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&client->dev, ret, "Can't get CS_RNG\n");
cs_rng = (ret >> 6) & GENMASK(1, 0);
ret = i2c_smbus_read_word_data(client, XDP710_V_SNS_CFG);
- if (ret < 0) {
- dev_err(&client->dev, "Can't get V_SNS_CFG");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&client->dev, ret, "Can't get V_SNS_CFG\n");
vtlm_rng = ret & GENMASK(1, 0);
ret = i2c_smbus_read_word_data(client, XDP710_REG_CFG);
- if (ret < 0) {
- dev_err(&client->dev, "Can't get REG_CFG");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&client->dev, ret, "Can't get REG_CFG\n");
ret &= GENMASK(5, 0);
rsense = micro_ohm_rsense[ret];
--
2.53.0