Re: [PATCH 2/4] selftests: ublk: propagate stress worker failures

From: Ming Lei

Date: Sat Nov 14 2026 - 21:29:10 EST


On Sat, Nov 14, 2026 at 8:07 PM Ming Lei <tom.leiming@xxxxxxxxx> wrote:
>
> On Wed, Nov 11, 2026 at 10:57:59PM +0800, shao.mingyin@xxxxxxxxxx wrote:
> > From: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
> >
> > The stress tests update ERR_CODE in background subshells and use a bare
> > wait in the parent. A worker can therefore fail while the parent still
> > prints PASS and exits successfully. Calling _show_result() from a worker
> > also removes backing files shared with other workers.
> >
> > Generalize the recovery PID collector and use it to wait for every stress
> > worker in the parent. Return errors from the worker helpers, leave result
> > reporting and cleanup to the parent, and reset the PID array after each
> > batch. Keep failures ahead of skips when collecting worker exit statuses.
> >
> > Fixes: bb2cabf23568 ("selftests: ublk: run stress tests in parallel")
> > Reported-by: Ming Lei <tom.leiming@xxxxxxxxx>
> > Link: https://lore.kernel.org/all/avJ0Vn9G7XhZv-XL@fedora-laptop/
> > Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
> > ---
>
> Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>

Reviewed-by: Ming Lei <tom.leiming@xxxxxxxxx>

Thanks,
Ming Lei