Re: [PATCH can-next v6 2/6] can: gs_usb: gs_can_start_xmit(): don't leak uninitialized memory over USB

From: Marc Kleine-Budde

Date: Sun Nov 15 2026 - 03:32:35 EST


On 14.11.2026 23:44:53, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
>
> Low priority / nit picks for your consideration:
>
> - [Low] can: gs_usb: inaccurate Fixes: trailer in commit message
>
> --
>
> > diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
> > --- a/drivers/net/can/usb/gs_usb.c
> > +++ b/drivers/net/can/usb/gs_usb.c
> > @@ -861,7 +861,7 @@ static netdev_tx_t gs_can_start_xmit(struct sk_buff *skb,
> > if (!urb)
> > goto nomem_urb;
> >
> > - hf = kmalloc(dev->hf_size_tx, GFP_ATOMIC);
> > + hf = kzalloc(dev->hf_size_tx, GFP_ATOMIC);
> > if (!hf)
> > goto nomem_hf;
> >
> >
>
> [Severity: Low]
> The Fixes: tag points at 26949ac935e3 ("can: gs_usb: add CAN-FD
> support"). As far as I can tell, the leak in gs_can_start_xmit() is
> older than the CAN-FD support.

will fix

pw-bot: cr

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature