[PATCH 0/3] scsi: target: iscsi: fix session use-after-free on non-leading login

From: Daniel Wade

Date: Sun Nov 15 2026 - 03:59:25 EST


A non-leading login can attach a connection to a session that
iscsit_close_connection() has already committed to freeing. The
connection ends up in full feature phase with conn->sess dangling and
its NOP-In timer walking freed memory. The same window leaves an armed
Time2Retain timer on a freed session when the login fails instead.

The bug dates to the driver's original merge in v3.1, but the fix keys
off ->session_close, which arrived in v5.7 with commit 57c46e9f33da
("scsi: target: fix hang when multiple threads try to destroy the same
iscsi session"), so a backport further back needs adjusting.

Tested with KASAN on mainline against a target with authentication=0
and one explicit ACL. Compile tested on x86_64.

A reproducer is available on request.

Daniel Wade (3):
scsi: target: iscsi: factor out iscsit_stop_kthreads()
scsi: target: iscsi: don't attach a connection to a closing session
scsi: target: iscsi: don't re-arm Time2Retain on a closing session

drivers/target/iscsi/iscsi_target.c | 6 +++
drivers/target/iscsi/iscsi_target_login.c | 66 ++++++++++++++++++++++-
drivers/target/iscsi/iscsi_target_login.h | 1 +
drivers/target/iscsi/iscsi_target_nego.c | 17 +-----
4 files changed, 74 insertions(+), 16 deletions(-)

--
2.39.0.windows.2