Re: [PATCH 5/7] hwmon: Add driver for Marvel AlphaServer environmental sensors
From: Magnus Lindholm
Date: Sun Nov 15 2026 - 04:47:38 EST
Hi,
On Sun, Nov 15, 2026 at 4:46 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On 11/14/26 18:50, Matt Turner wrote:
> ...
> >>> +``in[0-*]_alarm`` Sensor is in the warning or fault state
> >>
> >> Which one is it ? Is it distinct ? A "fault" means
> >> that the hardware is broken/defective. An alarm means that
> >> the voltage is too high or too low. A faulty channel
> >> should not be reported as alarm but as fault.
> >
> > It is always the voltage being out of range: Warning is the reading
> > outside the warning limits (5% from nominal), Failure outside the
> > failure limits (10%). Both are reported as in_alarm in v2. The limits
> > are not in the console's packet, so they are not exported.
> >
>
> This could be reported as inX_max_alarm and inX_crit_alarm.
>
Only if the direction is known. "Outside" covers both, and in_crit is
the critical max (Documentation/hwmon/sysfs-interface.rst, in_crit vs
in_lcrit), so an undervoltage would read as too high. Matt, if the first
threshold in the packet is the nominal, as the comment in 5/7 says,
comparing in_input against it would pick min/lcrit or max/crit;
otherwise in_alarm alone is the safe choice.
Magnus