Re: [PATCH v1 2/2] clk: tegra114: Add CSI pad clock gates

From: Svyatoslav Ryhel

Date: Sun Nov 15 2026 - 06:54:39 EST


нд, 15 лист. 2026 р. о 13:03 Jerome Brunet <jbrunet@xxxxxxxxxxxx> пише:
>
> > Tegra114 has CSI pad bits in both PLLD and PLLD2 clocks that are required
> > for the correct work of the CSI block. Add CSI pad A and pad B clock gates
> > with PLLD/PLLD2 parents, respectively.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> > ---
> > drivers/clk/tegra/clk-tegra114.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
> > index ec537efac692..08e425365469 100644
> > --- a/drivers/clk/tegra/clk-tegra114.c
> > +++ b/drivers/clk/tegra/clk-tegra114.c
> > @@ -1041,6 +1041,16 @@ static __init void tegra114_periph_clk_init(void __iomem *clk_base,
> > 0, 82, periph_clk_enb_refcnt);
> > clks[TEGRA114_CLK_DSIB] = clk;
> >
> > + /* csia_pad */
> > + clk = clk_register_gate(NULL, "csia_pad", "pll_d", CLK_SET_RATE_PARENT,
> > + clk_base + PLLD_BASE, 26, 0, &pll_d_lock);
> > + clks[TEGRA114_CLK_CSIA_PAD] = clk;
> > +
> > + /* csib_pad */
> > + clk = clk_register_gate(NULL, "csib_pad", "pll_d2", CLK_SET_RATE_PARENT,
> > + clk_base + PLLD2_BASE, 26, 0, &pll_d2_lock);
> > + clks[TEGRA114_CLK_CSIB_PAD] = clk;
> > +
>
> Change seems ok in itself, just a couple of things I'd like to check with you.
>
> Seems both the CSI and DSI can use the PLL D and D2. Can they be used concurrently ?
> If yes, are you sure you want to add CLK_SET_RATE_PARENT which the
> DSI counter part does not have ?
>

CSI pad clocks are used only by CSI and CSI does not change rate of
pad clocks. Saying "DSI counter part" would not be correct, DSI mux
switched DSI clock parent while csi pad clocks do not touch clock
layout of CSI nor DSI.

Same layout is used in Tegra30 and Tegra114 inherits it.

> Also the DSI get the PLL through a fixed factor 'out0' but not the CSI ? is it something
> you have checked ? it just seems a little odd.
>

Yes, out0 is a fixed div2 of DSI clocks and that is code reflection of
hardware. CSI pad clocks do not have this setup in the hardware.

> --
> Jerome
>