[PATCH v4 0/3] riscv: probes: reject probes inside an LR/SC sequence

From: Vladimir Kondratiev

Date: Sun Nov 15 2026 - 07:39:23 EST


Patch 1 fixes page fault reported by sashiko-bot@xxxxxxxxxx that
existed before this patch series

Patch 2 rejects probes inside the LR/SC sequence. This commit was
initially submitted as patch 1 of the series [1].
Detaching it from that series because it is not depending on other stuff.

Patch 3 adds KUnit test, suggested by
Xiaofeng Yuan <yuanxiaofeng@xxxxxxxxxxxxxxxxxx> in [2]

[1] https://patch.msgid.link/20261110-lrsc-only-v6-0-bafc3cc0fcae@xxxxxxxxxxxx
[2] https://lore.kernel.org/linux-riscv/20261019134121.1763-3-yuanxiaofeng@xxxxxxxxxxxxxxxxxx/

---
Changes in v4:
- Add KUnit test as suggested by Guo Ren <guoren@xxxxxxxxxx>, based on
work by Xiaofeng Yuan <yuanxiaofeng@xxxxxxxxxxxxxxxxxx>
- Scan for SC up to maximum possible sequence length. SPU does not know
about symbols, it is not correct to stop scanning at the end of
symbol. Globally visible symbol placed within LR/SC sequence should
not turn probe within the sequence into acceptable.
- Link to v3: https://patch.msgid.link/20261112-probes-in-lrsc-v3-0-a95089852a17@xxxxxxxxxxxx

Changes in v3:
- Fix lr/sc loop detection logic for lr at probe position
- Add "Fixes" trailers as suggested by sashiko-bot@xxxxxxxxxx
- Link to v2: https://patch.msgid.link/20261111-probes-in-lrsc-v2-0-b2525b7e1e8e@xxxxxxxxxxxx

Changes in v2:
- Allow kprobe on the LR itself unless it is part of the LR/SC loop.
- Fix error (reported by sashiko-bot@xxxxxxxxxx) where
arch_prepare_kprobe() returns -EILSEQ for LR/SC probes.
Make codes returned by arch_check_kprobe to indicate -EINVAL
if probe falls within the LR/SC loop, consistent with the case when
INSN_REJECTED returned by riscv_probe_decode_insn
- add patch fixing out-of-bounds read in riscv_probe_decode_insn()
reported by sashiko-bot@xxxxxxxxxx (as patch 1)
- Link to v1: https://patch.msgid.link/20261111-probes-in-lrsc-v1-1-4f99ddea5f68@xxxxxxxxxxxx

To: Paul Walmsley <pjw@xxxxxxxxxx>
To: Palmer Dabbelt <palmer@xxxxxxxxxxx>
To: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
To: Alexandre Ghiti <alex@xxxxxxxx>
To: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
To: Oleg Nesterov <oleg@xxxxxxxxxx>
To: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
To: Guo Ren <guoren@xxxxxxxxxx>
To: Pekka Enberg <penberg@xxxxxxxxxx>
To: Patrick Stählin <me@xxxxxxxx>
Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: linux-trace-kernel@xxxxxxxxxxxxxxx
Cc: Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx>
Signed-off-by: Vladimir Kondratiev <vladimir.kondratiev@xxxxxxxxxxxx>

---
Vladimir Kondratiev (3):
riscv: kprobes: fix out-of-bounds read in riscv_probe_decode_insn
riscv: probes: reject probes inside an LR/SC sequence
riscv: kprobes: add KUnit test for LR/SC sequence rejection

arch/riscv/include/asm/insn.h | 28 +++++++
arch/riscv/kernel/probes/decode-insn.c | 91 ++++++++++++++++++++++
arch/riscv/kernel/probes/decode-insn.h | 7 ++
arch/riscv/kernel/probes/kprobes.c | 28 +++++--
arch/riscv/kernel/probes/uprobes.c | 31 ++++++++
arch/riscv/kernel/tests/kprobes/test-kprobes-asm.S | 58 ++++++++++++++
arch/riscv/kernel/tests/kprobes/test-kprobes.c | 32 ++++++++
arch/riscv/kernel/tests/kprobes/test-kprobes.h | 6 ++
8 files changed, 274 insertions(+), 7 deletions(-)
---
base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222
change-id: 20261111-probes-in-lrsc-4ccde6cbf436

Best regards,
--
Vladimir Kondratiev <vladimir.kondratiev@xxxxxxxxxxxx>