Re: [PATCH v2 0/8] PM / devfreq: rockchip-dfi: cleanups
From: Choi Chanwoo
Date: Sun Nov 15 2026 - 08:20:34 EST
On 9/22/2026 5:32 AM, Sebastian Reichel wrote:
> This adds proper handling of the RK3588 clocks required for DDR memory
> monitoring, which involves adding them to the clock driver and the DT
> bindings first. The change is done in a backwards compatible way by
> marking them as CLK_IGNORE_UNUSED and using optional clock get in the
> DFI driver. The series also applies a few cleanups to the DFI driver
> while at it. This is done in preparation for RK3576 support, which
> will also come with some DFI specific clocks.
>
> As everything is done backwards compatible, patches do not need to
> be merged together. So Heiko can take the Rockchip specific patches
> and Chanwoo Choi can take the DFI driver patches.
>
> Changes in v2:
> - Link to v1: https://patch.msgid.link/20260917-rockchip-dfi-cleanup-v1-0-4f00a97a69a6@xxxxxxxxxxxxx
> - DT binding: Do not specify maxItems in the generic part as it has a list
> of items
> - DT binding: Only set minItems/maxItems for specific SoCs
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> ---
> Nicolas Frattaroli (8):
> dt-bindings: clock: rk3588: add PCLK_DDR_MON_CH clocks
> dt-bindings: devfreq: event: rockchip,dfi: add clocks to rk3588
> PM / devfreq: rockchip-dfi: move to per-variant const structs
> PM / devfreq: rockchip-dfi: add NO_INTERRUPT perf capability
> PM / devfreq: rockchip-dfi: use bulk clock APIs
> clk: rockchip: rk3588: add PCLK_DDR_MON_CH gate branches
> PM / devfreq: rockchip-dfi: make RK3588 use its clocks
> arm64: dts: rockchip: add dfi clocks on RK3588
>
> .../bindings/devfreq/event/rockchip,dfi.yaml | 70 +++++++--
> arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 4 +
> drivers/clk/rockchip/clk-rk3588.c | 8 ++
> drivers/devfreq/event/rockchip-dfi.c | 160 ++++++++++++++-------
> include/dt-bindings/clock/rockchip,rk3588-cru.h | 4 +
> 5 files changed, 184 insertions(+), 62 deletions(-)
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260917-rockchip-dfi-cleanup-feae6eefae9c
>
> Best regards,
> --
> Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
When I tried to apply them, there is conflict on devfreq-next branch.
I'd like you to resend this series on based on devfreq-next and [PATCH v2 0/7] PM / devfreq: rockchip-dfi: RK3576 support.
--
Best Regards,
Chanwoo Choi
Principal Engineer, Samsung Electronics