Re: [PATCH rtw-next v4 5/7] wifi: rtw88: prepare frequency-offset correction for more chips

From: Luka Gejak

Date: Sun Nov 15 2026 - 08:41:40 EST


Hi Jie Feng,

Thanks for the patch. One small suggestion below.

On November 15, 2026 12:43:31 PM GMT+01:00, Ho Jie Feng <hjf3108@xxxxxxxxx>
wrote:

> Promote chip specific functions into the common core for cfo tracking.
> These become helpers which can be used by the other drivers.

Could you name RTL8822C as the source of these helpers and mention that
the crystal register writes stay in the chip code? I think that would
make the split between the common tracking logic and the hardware
specific part clearer.

Best regards,
Luka Gejak