Re: [PATCH 01/13] ovl: don't warn when the lazy lowerdata lookup fails in ovl_d_real()
From: Amir Goldstein
Date: Sun Nov 15 2026 - 09:54:49 EST
On Sun, Nov 15, 2026 at 3:02 PM Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> ovl_d_real() looks up the data of a metacopy file in a data-only layer
> itself if nothing has done that yet. If that lookup fails it WARN()s and
> returns the overlayfs dentry.
>
> Commit 42dd69ae1af4 ("ovl: implement lazy lookup of lowerdata in
> data-only layers") assumed that the file would be read before
> trace_uprobe places a uprobe on it so the data would be there already.
>
> But nothing actually guarantees that. trace_uprobe takes the path from
> kern_path() and calls d_real_inode() on it when the event is created and
> again when it is enabled. So a uprobe on a metacopy file whose redirect
> points at nothing warns twice:
>
> ovl_d_real(/f, 0): real dentry not found
> WARNING: fs/overlayfs/super.c:79 at ovl_d_real+0xc9/0x210, CPU#2: sh/279
> Call Trace:
> <TASK>
> __trace_uprobe_create+0x1869/0x25b0
> trace_probe_create+0xcc/0xe0
> dyn_event_create+0x46/0x70
> create_or_delete_trace_uprobe+0x3c/0x70
> trace_parse_run_command+0x1a6/0x320
> vfs_write+0x1cd/0xfa0
> ksys_write+0x116/0x250
> do_syscall_64+0x10e/0x5e0
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
> </TASK>
>
> bpf's uprobe_multi does the same.
>
> A failed lookup isn't a bug though. The data can be missing, its verity
> digest can be wrong or a signal can interrupt the wait for the inode
> lock. ovl_open() simply fails in that case and
> ovl_maybe_lookup_lowerdata() already warns ratelimited about failed
> lookups. So return the overlayfs dentry without warning. That's what the
> WARN() path returned anyway.
>
> Fixes: 42dd69ae1af4 ("ovl: implement lazy lookup of lowerdata in data-only layers")
> Fixes: 184996e92e86 ("ovl: Validate verity xattr when resolving lowerdata")
Nit: 42dd69ae1af4 came first and opened the possibility of goto bug
and then 184996e92e86 came later and depends on 42dd69ae1af4.
I don't really see the benefit from stable POV to name the later as Fixes
> Cc: stable@xxxxxxxxxxxxxxx # v6.5+
> Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> Closes: https://lore.kernel.org/all/sashiko-outbox-214581@xxxxxxxxxx
> Reported-by: Chris Down <chris@xxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/all/20261114120557.4bc1eb6e57218cdc@xxxxxxxxxxxxxx
> Signed-off-by: Christian Brauner (Amutable) <brauner@xxxxxxxxxx>
Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>
> ---
> fs/overlayfs/super.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index 08695a99f4f93..1985b553a47b7 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -58,15 +58,13 @@ static struct dentry *ovl_d_real(struct dentry *dentry, enum d_real_type type)
>
> /*
> * Best effort lazy lookup of lowerdata for D_REAL_DATA case to return
> - * the real lowerdata dentry. The only current caller of d_real() with
> - * D_REAL_DATA is d_real_inode() from trace_uprobe and this caller is
> - * likely going to be followed reading from the file, before placing
> - * uprobes on offset within the file, so lowerdata should be available
> - * when setting the uprobe.
> + * the real lowerdata dentry. Callers may ask for files that were never
> + * opened, e.g. for uprobes or O_PATH files, so the lookup can fail
> + * here. Return the overlayfs dentry then.
> */
> err = ovl_verify_lowerdata(dentry);
> if (err)
> - goto bug;
> + return dentry;
> lower = ovl_dentry_lowerdata(dentry);
> if (!lower)
> goto bug;
>
> --
> 2.53.0
>